Fix empty TypeMeta while running API conversions #1422
Draft
+12,833
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
|
/fresh |
- Fix an issue with API conversions when the TypeMeta information has been dropped. - Add v1beta1 -> v1beta3 field renaming conversions for relevant resources (fast-tracked in commit 32ce2a9). - Do not replace but append conversion functions (fast-tracked in commit 32ce2a9). Signed-off-by: Alper Rifat Ulucinar <[email protected]>
The previous `make generate` wasn't committed separately. This one reflects changes because of Upjet commit [5cdf369][]. [5cdf369]: crossplane/upjet@5cdf369 Signed-off-by: Cem Mergenci <[email protected]>
mergenci
force-pushed
the
fix-conversion-typemeta
branch
from
e675588
to
d5405cb
Compare
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
/test-examples="examples/rds/v1beta2/instance.yaml" |
|
/test-examples="examples/ec2/v1beta1/vpcendpoint.yaml" |
|
/test-examples="examples/rds/v1beta1/instance.yaml" |
Signed-off-by: Cem Mergenci <[email protected]>
|
/test-examples="examples/ec2/v1beta1/vpcendpoint.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on: crossplane/upjet#424
To be completed... cc. @mergenci, @turkenf
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested against
crossplane-contrib/provider-upjet-awsresourceInstance.rdswith conversions between the versionsv1beta1&v1beta2.